[Enhancement]implement dayofweek in FE (backport #51453) #51804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
|
Cherry-pick of fb41039 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr |
Seaven
force-pushed
the
mergify/bp/branch-2.5/pr-51453
branch
from
1994fdb to
825b988
Compare
Seaven
previously approved these changes
Oct 12, 2024
Signed-off-by: evenhuang <[email protected]> (cherry picked from commit fb41039) Signed-off-by: even986025158 <[email protected]>
Seaven
force-pushed
the
mergify/bp/branch-2.5/pr-51453
branch
from
825b988 to
3799868
Compare
Seaven
approved these changes
Oct 12, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
If the where condition contains a partition condition that is compared with the dayofweek function, a full table scan will be required, and FE is required to implement the dayofweek function to perform partition pruning when generating the execution plan.
What I'm doing:
implement dayofweek in FE
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
FE支持DAYOFWEEK 函数
实现前:
实现后:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #51453 done by [Mergify](https://mergify.com). ## Why I'm doing: If the where condition contains a partition condition that is compared with the dayofweek function, a full table scan will be required, and FE is required to implement the dayofweek function to perform partition pruning when generating the execution plan. ## What I'm doing: implement dayofweek in FE Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
FE支持DAYOFWEEK 函数
实现前:
实现后:
